Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate log level when creating driver manager #212

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

Daemo00
Copy link
Contributor

@Daemo00 Daemo00 commented Jul 31, 2021

Otherwise first line is logged no matter what log_level is set during creation of driver manager.

Similar to #172

@codecov-commenter
Copy link

Codecov Report

Merging #212 (43aaeaf) into master (4743ac8) will increase coverage by 1.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   86.08%   87.15%   +1.07%     
==========================================
  Files          11       11              
  Lines         467      467              
  Branches       50       50              
==========================================
+ Hits          402      407       +5     
+ Misses         47       43       -4     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
webdriver_manager/manager.py 100.00% <100.00%> (ø)
webdriver_manager/driver.py 92.66% <0.00%> (+1.33%) ⬆️
webdriver_manager/utils.py 74.07% <0.00%> (+1.85%) ⬆️
webdriver_manager/archive.py 68.29% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4743ac8...43aaeaf. Read the comment docs.

@SergeyPirogov SergeyPirogov merged commit d38713d into SergeyPirogov:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants