From 9e54be0409d632001f5f6f4af6de187ee0da101e Mon Sep 17 00:00:00 2001 From: Sergey Myssak Date: Tue, 18 Apr 2023 07:32:57 +0600 Subject: [PATCH] Normalize interlink URL usage (#698) Co-authored-by: Andrey Myssak Signed-off-by: Sergey Myssak --- src-docs/src/views/badge/badge_example.js | 4 +++- src-docs/src/views/badge/beta_badge.js | 4 ++-- src-docs/src/views/button/button_as_link.js | 8 ++++---- src-docs/src/views/call_out/danger.js | 5 ++++- src-docs/src/views/call_out/info.js | 2 +- src-docs/src/views/call_out/warning.js | 6 ++---- src-docs/src/views/card/card_footer.js | 9 ++++++--- src-docs/src/views/card/card_image.js | 2 +- src-docs/src/views/card/card_layout.js | 2 +- .../src/views/datagrid/additional_controls.js | 2 +- src-docs/src/views/datagrid/container.js | 2 +- src-docs/src/views/datagrid/datagrid.js | 6 ++++-- src-docs/src/views/datagrid/in_memory.js | 6 ++++-- .../views/datagrid/in_memory_enhancements.js | 6 ++++-- .../views/datagrid/in_memory_pagination.js | 6 ++++-- .../src/views/datagrid/in_memory_sorting.js | 6 ++++-- src-docs/src/views/datagrid/virtualization.js | 6 ++++-- .../datagrid/virtualization_constrained.js | 6 ++++-- src-docs/src/views/flyout/flyout_banner.js | 3 ++- src-docs/src/views/header/header.js | 2 +- src-docs/src/views/header/header_alert.js | 12 +++++++++-- .../views/header/header_elastic_pattern.js | 4 +++- src-docs/src/views/header/header_example.js | 6 +++--- src-docs/src/views/header/header_sections.js | 2 +- src-docs/src/views/link/link.js | 20 +++++++++---------- src-docs/src/views/link/link_example.js | 4 ++-- src-docs/src/views/progress/progress_fixed.js | 2 +- src-docs/src/views/suggest/hashtag_popover.js | 4 ++-- src-docs/src/views/tables/auto/auto.js | 8 ++++---- src-docs/src/views/tables/basic/basic.js | 4 ++-- src-docs/src/views/tables/custom/custom.js | 10 ++++++++-- src-docs/src/views/text/playground.js | 4 ++-- src-docs/src/views/text/text.js | 7 ++++--- src-docs/src/views/text/text_color.js | 2 +- src-docs/src/views/toast/success.js | 5 ++++- src-docs/src/views/toast/toast_list.js | 5 ++++- src-docs/src/views/tool_tip/tool_tip.js | 2 +- 37 files changed, 119 insertions(+), 75 deletions(-) diff --git a/src-docs/src/views/badge/badge_example.js b/src-docs/src/views/badge/badge_example.js index 830bff3a13..655491886d 100644 --- a/src-docs/src/views/badge/badge_example.js +++ b/src-docs/src/views/badge/badge_example.js @@ -102,7 +102,9 @@ const badgeHealthSnippet = [ import BadgeHref from './badge_href'; const badgeHrefSource = require('!!raw-loader!./badge_href'); const badgeHrefHtml = renderToHtml(BadgeHref); -const badgeHrefSnippet = ['']; +const badgeHrefSnippet = [ + '', +]; import BadgeTruncate from './badge_truncate'; const badgeTruncateSource = require('!!raw-loader!./badge_truncate'); diff --git a/src-docs/src/views/badge/beta_badge.js b/src-docs/src/views/badge/beta_badge.js index d170250f6f..000330e191 100644 --- a/src-docs/src/views/badge/beta_badge.js +++ b/src-docs/src/views/badge/beta_badge.js @@ -64,13 +64,13 @@ export default () => (   diff --git a/src-docs/src/views/button/button_as_link.js b/src-docs/src/views/button/button_as_link.js index 06303d2edd..3b8625e204 100644 --- a/src-docs/src/views/button/button_as_link.js +++ b/src-docs/src/views/button/button_as_link.js @@ -36,7 +36,7 @@ export default () => ( @@ -45,20 +45,20 @@ export default () => ( - + Disabled link - + Disabled empty link (

Now you have to fix it, but maybe{' '} - this link can help. + + this link can help + + .

); diff --git a/src-docs/src/views/call_out/info.js b/src-docs/src/views/call_out/info.js index 27feb2d164..ed0295c304 100644 --- a/src-docs/src/views/call_out/info.js +++ b/src-docs/src/views/call_out/info.js @@ -25,7 +25,7 @@ export default () => (

When possible, its recommended to include links to product{' '} - + documentation . diff --git a/src-docs/src/views/call_out/warning.js b/src-docs/src/views/call_out/warning.js index 52bfea224c..6f4b7b0a31 100644 --- a/src-docs/src/views/call_out/warning.js +++ b/src-docs/src/views/call_out/warning.js @@ -18,12 +18,10 @@ export default () => (

This feature is experimental, and should not be run in production. For more information on this feature, visit{' '} - - documentation - + documentation .

- + Link button diff --git a/src-docs/src/views/card/card_footer.js b/src-docs/src/views/card/card_footer.js index 69ffae5da3..b55f6c759d 100644 --- a/src-docs/src/views/card/card_footer.js +++ b/src-docs/src/views/card/card_footer.js @@ -37,7 +37,8 @@ export default () => (

- Choice Two + Choice{' '} + Two

@@ -55,7 +56,8 @@ export default () => (

- Choice Two + Choice{' '} + Two

@@ -73,7 +75,8 @@ export default () => (

- Choice Two + Choice{' '} + Two

diff --git a/src-docs/src/views/card/card_image.js b/src-docs/src/views/card/card_image.js index 1306a9e960..b103eec9ed 100644 --- a/src-docs/src/views/card/card_image.js +++ b/src-docs/src/views/card/card_image.js @@ -57,7 +57,7 @@ export default () => ( } title={'Title'} diff --git a/src-docs/src/views/card/card_layout.js b/src-docs/src/views/card/card_layout.js index 4429611dfd..7cfc8c42bf 100644 --- a/src-docs/src/views/card/card_layout.js +++ b/src-docs/src/views/card/card_layout.js @@ -45,7 +45,7 @@ export default () => ( title={'No icon example'} description="Example of a card's description. Stick to one or two sentences." onClick={() => {}} - href="#" + href="https://oui.opensearch.org/latest/" /> diff --git a/src-docs/src/views/datagrid/additional_controls.js b/src-docs/src/views/datagrid/additional_controls.js index eb91b4a476..b09949038b 100644 --- a/src-docs/src/views/datagrid/additional_controls.js +++ b/src-docs/src/views/datagrid/additional_controls.js @@ -45,7 +45,7 @@ for (let i = 1; i < 20; i++) { ), email: faker.helpers.fake('{{internet.email}}'), city: ( - + {faker.helpers.fake('{{address.city}}')} ), diff --git a/src-docs/src/views/datagrid/container.js b/src-docs/src/views/datagrid/container.js index b55665f8c8..d49fd254d1 100644 --- a/src-docs/src/views/datagrid/container.js +++ b/src-docs/src/views/datagrid/container.js @@ -41,7 +41,7 @@ for (let i = 1; i < 20; i++) { ), email: faker.helpers.fake('{{internet.email}}'), city: ( - + {faker.helpers.fake('{{address.city}}')} ), diff --git a/src-docs/src/views/datagrid/datagrid.js b/src-docs/src/views/datagrid/datagrid.js index 35f717f13a..6fdfc22999 100644 --- a/src-docs/src/views/datagrid/datagrid.js +++ b/src-docs/src/views/datagrid/datagrid.js @@ -46,14 +46,16 @@ for (let i = 1; i < 100; i++) { }, email: { formatted: ( - {faker.helpers.fake('{{internet.email}}')} + + {faker.helpers.fake('{{internet.email}}')} + ), raw: email, }, location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/in_memory.js b/src-docs/src/views/datagrid/in_memory.js index 041cfc9d8b..a699190aad 100644 --- a/src-docs/src/views/datagrid/in_memory.js +++ b/src-docs/src/views/datagrid/in_memory.js @@ -50,12 +50,14 @@ for (let i = 1; i < 100; i++) { '{{name.lastName}}, {{name.firstName}} {{name.suffix}}' ), email: ( - {faker.helpers.fake('{{internet.email}}')} + + {faker.helpers.fake('{{internet.email}}')} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/in_memory_enhancements.js b/src-docs/src/views/datagrid/in_memory_enhancements.js index 9b47a5dd78..75abe70b3b 100644 --- a/src-docs/src/views/datagrid/in_memory_enhancements.js +++ b/src-docs/src/views/datagrid/in_memory_enhancements.js @@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { '{{name.lastName}}, {{name.firstName}} {{name.suffix}}' ), email: ( - {faker.helpers.fake('{{internet.email}}')} + + {faker.helpers.fake('{{internet.email}}')} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/in_memory_pagination.js b/src-docs/src/views/datagrid/in_memory_pagination.js index 358380ab05..ad911c60e1 100644 --- a/src-docs/src/views/datagrid/in_memory_pagination.js +++ b/src-docs/src/views/datagrid/in_memory_pagination.js @@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { '{{name.lastName}}, {{name.firstName}} {{name.suffix}}' ), email: ( - {faker.helpers.fake('{{internet.email}}')} + + {faker.helpers.fake('{{internet.email}}')} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/in_memory_sorting.js b/src-docs/src/views/datagrid/in_memory_sorting.js index 31b088260f..704f0eec02 100644 --- a/src-docs/src/views/datagrid/in_memory_sorting.js +++ b/src-docs/src/views/datagrid/in_memory_sorting.js @@ -49,12 +49,14 @@ for (let i = 1; i < 100; i++) { '{{name.lastName}}, {{name.firstName}} {{name.suffix}}' ), email: ( - {faker.helpers.fake('{{internet.email}}')} + + {faker.helpers.fake('{{internet.email}}')} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/virtualization.js b/src-docs/src/views/datagrid/virtualization.js index 004316c6b1..f708da16e5 100644 --- a/src-docs/src/views/datagrid/virtualization.js +++ b/src-docs/src/views/datagrid/virtualization.js @@ -82,11 +82,13 @@ function RenderCellValue({ rowIndex, columnId }) { const suffix = faker.helpers.fake('{{name.suffix}}'); data[rowIndex] = { name: `${name} ${suffix}`, - email: {email}, + email: ( + {email} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/datagrid/virtualization_constrained.js b/src-docs/src/views/datagrid/virtualization_constrained.js index e26f90613b..c93e073843 100644 --- a/src-docs/src/views/datagrid/virtualization_constrained.js +++ b/src-docs/src/views/datagrid/virtualization_constrained.js @@ -80,11 +80,13 @@ function RenderCellValue({ rowIndex, columnId }) { const suffix = faker.helpers.fake('{{name.suffix}}'); data[rowIndex] = { name: `${name} ${suffix}`, - email: {email}, + email: ( + {email} + ), location: ( {`${faker.helpers.fake('{{address.city}}')}, `} - + {faker.helpers.fake('{{address.country}}')} diff --git a/src-docs/src/views/flyout/flyout_banner.js b/src-docs/src/views/flyout/flyout_banner.js index 1f50693aa2..b9f99b3a4e 100644 --- a/src-docs/src/views/flyout/flyout_banner.js +++ b/src-docs/src/views/flyout/flyout_banner.js @@ -35,7 +35,8 @@ export default () => {

Here’s some stuff that you need to know. This banner helps - highlight important information. View docs + highlight important information.{' '} + View docs

); diff --git a/src-docs/src/views/header/header.js b/src-docs/src/views/header/header.js index f794507509..9b2f21216c 100644 --- a/src-docs/src/views/header/header.js +++ b/src-docs/src/views/header/header.js @@ -38,7 +38,7 @@ export default () => { const renderLogo = () => ( e.preventDefault()} aria-label="Go to home page" /> diff --git a/src-docs/src/views/header/header_alert.js b/src-docs/src/views/header/header_alert.js index 86f52980ec..e046d81859 100644 --- a/src-docs/src/views/header/header_alert.js +++ b/src-docs/src/views/header/header_alert.js @@ -48,7 +48,11 @@ const HeaderUpdates = () => { { title: 'Control access to features', text: 'Show or hide applications and features per space in Kibana.', - action: Learn about feature controls, + action: ( + + Learn about feature controls + + ), date: '1 May 2019', badge: 7.1, }, @@ -71,7 +75,11 @@ const HeaderUpdates = () => { title: 'Enter dark mode', text: 'Kibana now supports the easy-on-the-eyes theme across the entire UI.', - action: Go to Advanced Settings, + action: ( + + Go to Advanced Settings + + ), date: '10 April 2019', badge: 7.0, }, diff --git a/src-docs/src/views/header/header_elastic_pattern.js b/src-docs/src/views/header/header_elastic_pattern.js index c1a909ee86..4b0f6663eb 100644 --- a/src-docs/src/views/header/header_elastic_pattern.js +++ b/src-docs/src/views/header/header_elastic_pattern.js @@ -283,7 +283,9 @@ export default ({ theme }) => { sections={[ { items: [ - + OpenSearch , deploymentMenu, diff --git a/src-docs/src/views/header/header_example.js b/src-docs/src/views/header/header_example.js index 342538c117..bd3809cf11 100644 --- a/src-docs/src/views/header/header_example.js +++ b/src-docs/src/views/header/header_example.js @@ -95,16 +95,16 @@ const headerLinksSnippet = ` - + - + diff --git a/src-docs/src/views/header/header_sections.js b/src-docs/src/views/header/header_sections.js index a68f414785..9b2c648185 100644 --- a/src-docs/src/views/header/header_sections.js +++ b/src-docs/src/views/header/header_sections.js @@ -28,7 +28,7 @@ export default () => { const renderLogo = ( e.preventDefault()} aria-label="Navigate to home page" /> diff --git a/src-docs/src/views/link/link.js b/src-docs/src/views/link/link.js index 4e73a49d08..c3b6583461 100644 --- a/src-docs/src/views/link/link.js +++ b/src-docs/src/views/link/link.js @@ -17,7 +17,7 @@ export default () => (

Open the{' '} - + OpenSearch website {' '} in a new tab. Setting target=“_blank” also @@ -25,7 +25,7 @@ export default () => (

This{' '} - + link {' '} has the external prop set to true. @@ -37,7 +37,7 @@ export default () => (

Here is an example of a{' '} { e.preventDefault(); }}> @@ -49,38 +49,38 @@ export default () => (

Links can be colored as well.

  • - + subdued
  • - + success
  • - + accent
  • - + danger
  • - + warning
  • - + text
  • - + ghost diff --git a/src-docs/src/views/link/link_example.js b/src-docs/src/views/link/link_example.js index e84201701b..ff3aaae6a3 100644 --- a/src-docs/src/views/link/link_example.js +++ b/src-docs/src/views/link/link_example.js @@ -33,9 +33,9 @@ const linkValidationSource = require('!!raw-loader!./link_validation'); const linkValidationHtml = renderToHtml(LinkValidation); const linkSnippet = [ - ` + ` `, - ` + ` `, diff --git a/src-docs/src/views/progress/progress_fixed.js b/src-docs/src/views/progress/progress_fixed.js index a35359aee2..74c48d1034 100644 --- a/src-docs/src/views/progress/progress_fixed.js +++ b/src-docs/src/views/progress/progress_fixed.js @@ -95,7 +95,7 @@ export default () => { diff --git a/src-docs/src/views/suggest/hashtag_popover.js b/src-docs/src/views/suggest/hashtag_popover.js index 8bffe562b3..c38cadadfd 100644 --- a/src-docs/src/views/suggest/hashtag_popover.js +++ b/src-docs/src/views/suggest/hashtag_popover.js @@ -71,7 +71,7 @@ export default (props) => { iconType: 'trash', iconSize: 's', }} - href="#" + href="https://oui.opensearch.org/latest/" label="Popular shoes in America" /> { iconType: 'trash', iconSize: 's', }} - href="#" + href="https://oui.opensearch.org/latest/" label="Popular shirts in Canada" /> diff --git a/src-docs/src/views/tables/auto/auto.js b/src-docs/src/views/tables/auto/auto.js index 428a93311a..c530fb840e 100644 --- a/src-docs/src/views/tables/auto/auto.js +++ b/src-docs/src/views/tables/auto/auto.js @@ -58,7 +58,7 @@ const columns = [ render: (item) => ( {item.firstName}{' '} - + {item.lastName} @@ -73,7 +73,7 @@ const columns = [ field: 'lastName', name: 'Last Name', render: (name) => ( - + {name} ), @@ -99,7 +99,7 @@ const customColumns = [ render: (item) => ( {item.firstName}{' '} - + {item.lastName} @@ -114,7 +114,7 @@ const customColumns = [ field: 'lastName', name: 'Last Name', render: (name) => ( - + {name} ), diff --git a/src-docs/src/views/tables/basic/basic.js b/src-docs/src/views/tables/basic/basic.js index d0dd9d2ea5..f22486f6ef 100644 --- a/src-docs/src/views/tables/basic/basic.js +++ b/src-docs/src/views/tables/basic/basic.js @@ -54,7 +54,7 @@ export const Table = () => { render: (item) => ( {item.firstName}{' '} - + {item.lastName} @@ -70,7 +70,7 @@ export const Table = () => { name: 'Last Name', truncateText: true, render: (name) => ( - + {name} ), diff --git a/src-docs/src/views/tables/custom/custom.js b/src-docs/src/views/tables/custom/custom.js index ff69198bf1..1a3c826329 100644 --- a/src-docs/src/views/tables/custom/custom.js +++ b/src-docs/src/views/tables/custom/custom.js @@ -587,7 +587,9 @@ export default class extends Component { ? item.title.value : item.title; const title = item.title.isLink ? ( - {item.title.value} + + {item.title.value} + ) : ( titleText ); @@ -595,7 +597,11 @@ export default class extends Component { } else if (column.cellProvider) { child = column.cellProvider(cell); } else if (cell.isLink) { - child = {cell.value}; + child = ( + + {cell.value} + + ); } else if (cell.truncateText) { child = cell.value; } else { diff --git a/src-docs/src/views/text/playground.js b/src-docs/src/views/text/playground.js index 2c2a86edcd..83793a46cb 100644 --- a/src-docs/src/views/text/playground.js +++ b/src-docs/src/views/text/playground.js @@ -23,8 +23,8 @@ export const textConfig = () => { type: PropTypes.ReactNode, value: `

    This is Heading One

    - Ea mollit ullamco cillum ipsum adipisicing ea aute id. Cillum unfashionable amet - proident irure Lorem irure consequat veniam. Excepteur exercitation ex officia + Ea mollit ullamco cillum ipsum adipisicing ea aute id. Cillum unfashionable amet + proident irure Lorem irure consequat veniam. Excepteur exercitation ex officia minim excepteur consequat sint id Lorem est officia cupidatat excepteur commodo.

    `, hidden: false, diff --git a/src-docs/src/views/text/text.js b/src-docs/src/views/text/text.js index 3e88c919b9..197cad6f49 100644 --- a/src-docs/src/views/text/text.js +++ b/src-docs/src/views/text/text.js @@ -19,9 +19,10 @@ export default () => (

    This is Heading One

    Veniam et quis in dolor aliqua dolor laboris nostrud nostrud Lorem. - unfashionable Irure et et adipisicing eu mollit. Ullamco - laborum cillum ea id occaecat cupidatat ex dolor consequat ex mollit do. - Irure commodo incididunt reprehenderit deserunt cillum quis ad nostrud!{' '} + unfashionable Irure et + et adipisicing eu mollit. Ullamco laborum cillum ea id occaecat + cupidatat ex dolor consequat ex mollit do. Irure commodo incididunt + reprehenderit deserunt cillum quis ad nostrud!{' '} const whoa = "!"

    diff --git a/src-docs/src/views/text/text_color.js b/src-docs/src/views/text/text_color.js index e7c3290df8..6b68508b59 100644 --- a/src-docs/src/views/text/text_color.js +++ b/src-docs/src/views/text/text_color.js @@ -68,7 +68,7 @@ export default () => ( Sometimes you need to color entire blocks of text, no matter what is in them. You can always apply color directly (versus using the separated component) to make it easy. Links should still{' '} - properly color. + properly color.

    diff --git a/src-docs/src/views/toast/success.js b/src-docs/src/views/toast/success.js index 3d4f0f31c3..4ac0f313f2 100644 --- a/src-docs/src/views/toast/success.js +++ b/src-docs/src/views/toast/success.js @@ -33,7 +33,10 @@ export default () => (

    And some other stuff on another line, just for kicks. And{' '} - here’s a link. + + here’s a link + + .

    diff --git a/src-docs/src/views/toast/toast_list.js b/src-docs/src/views/toast/toast_list.js index 166ee0ec50..97f1c75577 100644 --- a/src-docs/src/views/toast/toast_list.js +++ b/src-docs/src/views/toast/toast_list.js @@ -62,7 +62,10 @@ export default () => {

    And some other stuff on another line, just for kicks. And{' '} - here’s a link. + + here’s a link + + .

    ), diff --git a/src-docs/src/views/tool_tip/tool_tip.js b/src-docs/src/views/tool_tip/tool_tip.js index 3657ecb54e..b018b3663f 100644 --- a/src-docs/src/views/tool_tip/tool_tip.js +++ b/src-docs/src/views/tool_tip/tool_tip.js @@ -27,7 +27,7 @@ export default () => (

    This tooltip appears on the{' '} - top + top