Skip to content
This repository has been archived by the owner on May 18, 2024. It is now read-only.

redux-thunk相容性問題 #84

Closed
wenchen opened this issue Jun 5, 2018 · 3 comments
Closed

redux-thunk相容性問題 #84

wenchen opened this issue Jun 5, 2018 · 3 comments

Comments

@wenchen
Copy link
Contributor

wenchen commented Jun 5, 2018

Describe the bug
redux-thunk與v2.3.0不相容, 在編譯的時候會出現
(14,84): Type 'Middleware' is not generic.
在redux-thunk的release note有詳述這件事情 https://github.com/reduxjs/redux-thunk/releases
他們提供的建議是,要不是停在 v2.2.0 不然就是 升級到redux 4.0

To Reproduce

  1. git clone
  2. 改tsconfig.js 加入baseUrl到compilerOptions, 先設定為”/“
  3. npm install yarn -g
  4. npm install
  5. yarn run build
  6. See error
    

Expected behavior
可以正常編譯

Screenshots
wenchenx@ggv:~/ggvworkdir/sensetw/sensemap/src$ NODE_ENV=development yarn run build
yarn run v1.7.0
$ react-scripts-ts build
Creating an optimized production build...
Starting type checking and linting service...
Using 1 worker with 2048MB memory limit
ts-loader: Using [email protected] and /home/wenchenx/ggvworkdir/sensetw/sensemap/tsconfig.json
No valid rules have been specified for JavaScript files
Failed to compile.

/home/wenchenx/ggvworkdir/sensetw/sensemap/node_modules/redux-thunk/index.d.ts
(14,84): Type 'Middleware' is not generic.

error Command failed with exit code 1.
{
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Desktop (please complete the following information):

  • OS: ubuntu 16.04.4

Additional context
Add any other context about the problem here.

@caasi
Copy link
Contributor

caasi commented Jun 5, 2018

see also: #80 (comment)

@wenchen
Copy link
Contributor Author

wenchen commented Jun 5, 2018

這邊大概哪時候會merge回master呀

@pm5
Copy link
Contributor

pm5 commented Jun 5, 2018

Step 4 should be yarn instead of npm install.

So this is solved?

@pm5 pm5 closed this as completed Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants