Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Message] - Compact class incompatible with icon class #4759

Open
dmaison opened this issue Nov 17, 2016 · 6 comments
Open

[Message] - Compact class incompatible with icon class #4759

dmaison opened this issue Nov 17, 2016 · 6 comments

Comments

@dmaison
Copy link

dmaison commented Nov 17, 2016

Steps to Reproduce

  1. Create <div class="ui compact icon message" />

Expected
The Message should do be producing an icon message that is compact

Result
The compact class is ignored and element is displayed as block (full width)

Testcase
(fork this to get started)
http://jsfiddle.net/95kzk6mr/1/

@designosis
Copy link

Confirmed ... +1

@jlukic jlukic added this to the 2.2.8 milestone Dec 6, 2016
@jlukic jlukic modified the milestones: 2.2.10, 2.2.11 Mar 28, 2017
@jlukic
Copy link
Member

jlukic commented Jul 3, 2017

Fixed in 2.2.11

@designosis
Copy link

designosis commented Aug 10, 2017

@jlukic Hey there ... ui compact icon message still doesn't work. See the original Testcase above (http://jsfiddle.net/95kzk6mr/1/), it still renders at 100% width.

Neither 2.2.11 (where the fix was introduced) nor the latest 2.2.13 solve the issue.

I think what's happening is that .ui.icon.message sets width:100%.
So this problem may simply be fixed by adding the following CSS:

.ui.compact.icon.message {
    width: auto;
}

@stale
Copy link

stale bot commented Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Jun 5, 2018
@GammaGames
Copy link
Contributor

GammaGames commented Jun 25, 2018

Seems like a simple fix, though I'm sure they don't want a lot of special case css in the library because it would make it harder to maintain. I override it with a similar rule as above for now. Maybe Fomantic will fix it

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants