Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's SUI recommended architecture for custom style in myself folder? #1555

Closed
hpyhacking opened this issue Jan 3, 2015 · 6 comments
Closed

Comments

@hpyhacking
Copy link

I'm use Rails build some sites, but I'm use browserify and gulp build less and coffee for my site.

I have a doubt when read running-installer, "SUI is recommended to build the site in its own directory it?"

Now I'm link ./node_modules/semantic-ui/src/site/* to my site folder MY_SITE/app/assets/stylesheets/* to custom style for my site, but it's so strange.

What's SUI recommended architecture for custom style in myself folder?

@jlukic

@hpyhacking hpyhacking changed the title What's SUI recommended architecture for custom style in MYSELF FOLDER? What's SUI recommended architecture for custom style in myself folder? Jan 3, 2015
@anestv
Copy link

anestv commented Jan 3, 2015

At ./node_modules/semantic-ui/src/site/* there are your site's variables and overrides (part of the source code).

The css and js files which you should link to MY_SITE/app/assets/* are in ./node_modules/semantic-ui/dist/

@hpyhacking
Copy link
Author

This's strange.

We usually add node_modules to .gitignore and this folder just store library. Why my site's variables and overrides in a library folder?

I hope import SUI less version just like @import 'semantic-ui/semantic-ui and insert my site's variables and overrides before this import line, or other one good idea? @anestv

@faller
Copy link

faller commented Jan 3, 2015

@hpyhacking

I have faced the same problem with you. You may need some Asian typography optimization, forking SUI and install it by bower is a good way.

By the way, I enjoy using SUI with webpack, which is better than browserfiy

@anestv
Copy link

anestv commented Jan 3, 2015

If you want to customise Semantic then you will need to modify some variables from your site (src/site) or theme (src/themes/themeName) (mostly globals/site variables) and then build (using gulp). If you have modified some variables, I think you would want to not gitignore the folder.

To include the compiled Semantic UI files (css and js) in an html page, you will have you use the files from dist/.

If you try to include files from src/site in html nothing should happen because browsers shouldn't understand .less files.

If you want to include Semantic's source (.less) in some other less files you have, I don't know how you could do it

@jlukic
Copy link
Member

jlukic commented Jan 3, 2015

See Build Tools Issued thread #1385. I discuss the current issues there.

I recommend (for now) using the zip file instead of managing inside a package folder for bower or npm. Bower and npm will wipe settings on upgrade because they've decided to treat their component folder similarly to a temp folder.

@jlukic
Copy link
Member

jlukic commented Jan 5, 2015

Continued discussion in #1385, closing

@jlukic jlukic closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants