Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage layout problem #3398

Closed
john012343210 opened this issue Jan 23, 2019 · 7 comments
Closed

Homepage layout problem #3398

john012343210 opened this issue Jan 23, 2019 · 7 comments

Comments

@john012343210
Copy link

I think there is a bug in the official demonstration in semantic-ui-react

https://react.semantic-ui.com/layouts/homepage/

It is Okay when you open it the first time, however, when you refresh the page, it becomes messy. Where is the bug?

A clear and concise description of steps to reproduce the problem.

Expected Result

image

Actual Result

image

@welcome
Copy link

welcome bot commented Jan 23, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

Was fixed in #3373.

@john012343210
Copy link
Author

Was fixed in #3373.
Sorry but I think the bug remains,
I have downloaded the code and run on local to test it.
You can also try to visit
https://react.semantic-ui.com/layouts/homepage/
and refresh the page to reproduce the bug.

@layershifter
Copy link
Member

It was fixed, but was not released yet 🏷 Served locally (yarn build:docs:staging) production build and everything is fine there:

image

@john012343210
Copy link
Author

Thanks so much for your reply. May I ask one silly question?
image
There are 3 files changed corresponding to this issue.
I am already using the updated version of the middle file , which is HomepageLayout.js.
But the bug remains. Is it because HomepageLayout.js. file rely on the first and third file?

@layershifter
Copy link
Member

But the bug remains.

Sorry, what do you mean? I don't understand. You have issues with Responsive and SSR?
Please check #3361 (comment) and https://codesandbox.io/s/ly3zpw7yzm

@john012343210
Copy link
Author

Oh.Thank you so much. All 3 solutions provided by you are great. The NoSSR component works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants