Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking about the Sidebar implement #2893

Closed
luubinhan opened this issue Jun 8, 2018 · 2 comments
Closed

Rethinking about the Sidebar implement #2893

luubinhan opened this issue Jun 8, 2018 · 2 comments
Labels

Comments

@luubinhan
Copy link

The way we implement the Sidebar component I think it still have room to improve

With the overlay Sidebar, why do we need to put the children component inside <Sidebar.Pusher />, in somecase it's not nessesary and raise some issue, beause sometimes we could put our content inside <Sidebar.Pusher />

I found it more straight forwards, and more independent with
https://material-ui.com/demos/drawers/
or
https://developer.microsoft.com/en-us/fabric#/components/panel

@welcome
Copy link

welcome bot commented Jun 8, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

I will close this issue because we use SUI CSS now and current markup is required. However, I agree it's not friendly. Possible we can make changes in markup in v2.

BTW, the Sidebar component will receive some improvements in near future, see #2845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants