You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way we implement the Sidebar component I think it still have room to improve
With the overlay Sidebar, why do we need to put the children component inside <Sidebar.Pusher />, in somecase it's not nessesary and raise some issue, beause sometimes we could put our content inside <Sidebar.Pusher />
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.
We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
I will close this issue because we use SUI CSS now and current markup is required. However, I agree it's not friendly. Possible we can make changes in markup in v2.
BTW, the Sidebar component will receive some improvements in near future, see #2845.
The way we implement the Sidebar component I think it still have room to improve
With the overlay Sidebar, why do we need to put the children component inside <Sidebar.Pusher />, in somecase it's not nessesary and raise some issue, beause sometimes we could put our content inside <Sidebar.Pusher />
I found it more straight forwards, and more independent with
https://material-ui.com/demos/drawers/
or
https://developer.microsoft.com/en-us/fabric#/components/panel
The text was updated successfully, but these errors were encountered: