-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid: Column "tablet" value applied to other sizes #2869
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
In fact you cannot use responsive props with |
@jshado1 @layershifter More generally, I always thought it was a common pattern to set a base width (usually aimed at mobile) and override at various responsive widths where necessary. The reason I'm posting this now is because I've just come back to a project where I was using this pattern and am now getting the proptype warnings from #3184 after upgrading SUI-R. The alternative is to set the prop for every screen width which is really less than ideal. Problem is I'm not even sure it's worth opening an issue on the SUI repo about this, given its current status. I'll probably do so on Fomantic-UI, but given that SUI-R tracks the official SUI, it seems I would be stuck with the proptype warnings either way. |
Bug Report
This may be a bug for SUI-LESS.
Steps
Expected Result
I'm not sure if this is a bug or an unsupported mixing of properties (which is not documented), but it seems like a bug. Based on the documentation, I think bug:
That says to me that the value from
tablet
applies only to tablet (it's basically an exception); the value forwidth
applies to all sizes for which no exception has been specified.Actual Result
The values of
tablet
andwidth
conflict: sometimestablet
wins and sometimeswidth
wins. This is due to both having the same specificity (with no media query) and the last-wins rule.Version
SUIR
0.80.0
SUIL
2.3.1
Testcase
https://codesandbox.io/s/nn1n03o32p
Notice that the
tablet
value is used for the first column and thewidth
value is used for the second column (which causes the total to be greater than 16 aka 100%).The text was updated successfully, but these errors were encountered: