Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: should have inverted prop #1673

Closed
tobiashort opened this issue May 12, 2017 · 2 comments · Fixed by #1677
Closed

Grid: should have inverted prop #1673

tobiashort opened this issue May 12, 2017 · 2 comments · Fixed by #1677
Labels
enhancement good first issue help wanted

Comments

@tobiashort
Copy link

tobiashort commented May 12, 2017 •
edited
Loading

Steps

Divided grid with the "inverted" attribute on a dark background

Expected Result

Grid dividers are inverted and visible

Actual Result

Grid does not accept "inverted" attribute. Dividers are too dark to be recognized on a dark background

Version

0.68.3

Workaround

<Grid className="inverted">
</Grid>
@layershifter
Copy link
Member

layershifter commented May 12, 2017 •
edited
Loading

As I see, Grid can really be inverted. We should add an inverted prop to Grid with docs example.

@layershifter layershifter changed the title Grid should be invertable Grid: should have inverted prop May 12, 2017
@josie11 josie11 mentioned this issue May 14, 2017
Merged
@levithomason
Copy link
Member

Fixed in #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Grid): add inverted prop and usage example to docs josie11/Semantic-UI-React
3 participants
@levithomason @tobiashort @layershifter