From b40dd0ee4f2b59d49febaf247204bb4b09cea19c Mon Sep 17 00:00:00 2001 From: Viet Nguyen Duc Date: Wed, 6 Nov 2024 14:35:40 +0700 Subject: [PATCH] [py] Add test for warning when embedding user:pass in URL Signed-off-by: Viet Nguyen Duc --- .../selenium/webdriver/remote/remote_connection_tests.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/py/test/unit/selenium/webdriver/remote/remote_connection_tests.py b/py/test/unit/selenium/webdriver/remote/remote_connection_tests.py index 2a50b2ebe26831..2d86959f5bcaab 100644 --- a/py/test/unit/selenium/webdriver/remote/remote_connection_tests.py +++ b/py/test/unit/selenium/webdriver/remote/remote_connection_tests.py @@ -69,8 +69,13 @@ def test_get_remote_connection_headers_defaults(): def test_get_remote_connection_headers_adds_auth_header_if_pass(): url = "http://user:pass@remote" - headers = RemoteConnection.get_remote_connection_headers(parse.urlparse(url)) + with pytest.warns(None) as record: + headers = RemoteConnection.get_remote_connection_headers(parse.urlparse(url)) assert headers.get("Authorization") == "Basic dXNlcjpwYXNz" + assert ( + record[0].message.args[0] + == "Embedding username and password in URL could be insecure, use ClientConfig instead" + ) def test_get_remote_connection_headers_adds_keep_alive_if_requested():