From 85f589e5cec8dfac7ea697acc82fb37a8db07699 Mon Sep 17 00:00:00 2001 From: Puja Jagani Date: Tue, 27 Aug 2024 16:31:09 +0530 Subject: [PATCH] [dotnet] Disable setting 'websocketurl' capability for Chrome tests --- dotnet/test/common/BUILD.bazel | 2 +- dotnet/test/common/Environment/DriverFactory.cs | 7 ++++++- .../bidi/browsingcontext/BrowsingContextInspectorTest.java | 1 - 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/dotnet/test/common/BUILD.bazel b/dotnet/test/common/BUILD.bazel index 4c152aadf03c4..231781fd6d5ec 100644 --- a/dotnet/test/common/BUILD.bazel +++ b/dotnet/test/common/BUILD.bazel @@ -65,7 +65,7 @@ csharp_library( dotnet_nunit_test_suite( name = "AllTests", - size = "large", + size = "small", srcs = glob([ "**/*Test.cs", "**/*Tests.cs", diff --git a/dotnet/test/common/Environment/DriverFactory.cs b/dotnet/test/common/Environment/DriverFactory.cs index 448dfc61d1a98..8ce615235dc7d 100644 --- a/dotnet/test/common/Environment/DriverFactory.cs +++ b/dotnet/test/common/Environment/DriverFactory.cs @@ -67,7 +67,12 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO { browser = Browser.Chrome; options = GetDriverOptions(driverType, driverOptions); - options.UseWebSocketUrl = true; + // Disabling this since we do not have any BiDi tests currently. + //options.UseWebSocketUrl = true; + + // If BiDi is enabled above then the undhandler prompt behaviour needs to set accordingly. + // Reasoning : https://github.com/SeleniumHQ/selenium/pull/14429#issuecomment-2311614822 + //options.UnhandledPromptBehavior = UnhandledPromptBehavior.Ignore; var chromeOptions = (ChromeOptions)options; chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage"); diff --git a/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java b/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java index 16256f9ad5a4d..a92110c96eb15 100644 --- a/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java +++ b/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java @@ -34,7 +34,6 @@ import org.openqa.selenium.environment.webserver.AppServer; import org.openqa.selenium.environment.webserver.NettyAppServer; import org.openqa.selenium.testing.JupiterTestBase; -import org.openqa.selenium.testing.NotYetImplemented; class BrowsingContextInspectorTest extends JupiterTestBase {