Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #855

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Update README.md #855

merged 1 commit into from
Dec 19, 2018

Conversation

oleg-filiutsich
Copy link
Contributor

Add shared volume in docker compose swarm 3

Add shared volume in docker compose swarm 3
@ddavison
Copy link
Member

ddavison commented Dec 19, 2018

the issue is closed now, but i wonder if it's worth mentioning the bit that's in #721.

In order to mount /dev/shm on a windows machine is to specify set COMPOSE_CONVERT_WINDOWS_PATHS=1

that being said though, i like the change 🎉 💯

@diemol
Copy link
Member

diemol commented Dec 19, 2018

But according to this, the bug was already fixed in docker-compose for Windows.

@diemol
Copy link
Member

diemol commented Dec 19, 2018

Thanks for your contribution @oleg-filiutsich!

@diemol diemol merged commit bb9c70a into SeleniumHQ:master Dec 19, 2018
@ddavison
Copy link
Member

ddavison commented Dec 20, 2018

fantastic. thanks @diemol, @oleg-filiutsich !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants