-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: Disabling VNC does not quite work #2500
Comments
@MJB222398, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Try to use Node version 4.26.0+, I think it will be fixed by SeleniumHQ/selenium#14584 |
@VietND96 Thanks, unfortunately I cannot update right now due to other bugs/deprecations/limitations so I will take your word for it. Looking at your PR though I see it only deals with the SE_ prefixed versions of the variables. My understanding from reading other code was that these SE_ prefixed ones are only used as fallbacks if the unprefixed ones are not set. So I suppose my questions is, if I were to upgrade to 4.26+ could you be explicit about which variables (out of START_VNC, START_NO_VNC, START_XVFB, SE_START_VNC, SE_START_NO_VNC, SE_START_XVFB) I need to set to disable any and all VNC servers for my peace of mind? |
It's AND logic, so just one env var is false e.g SE_START_VNC=false, the recorder icon should be disabled (in the container, VNC will not start, and noVNC as well). |
@VietND96 Ok thanks, I just noticed also in the logs that I get this:
Doesn't seem right? |
Let me check it. It should not spawn pid again with a confused message. |
What happened?
I have to use a poverty spec machine so need to conserve resources. I do not need VNC so I want to disable that to save memory etc. I set the following environment variables:
This does seem to disable VNC in the sense that I can longer connect using my VNC client. However if I look at the Selenium Grid web UI at http://localhost:4444/ui/# this doesn't appear to reflect this properly.
Hovering over the '1' icon for my Chrome Node I can see the following:
{"browserName":"chrome","browserVersion":"127.0","goog:chromeOptions":{"binary":"/usr/bin/google-chrome"},"platformName":"linux","se:containerName":"","se:noVncPort":7900,"se:vncEnabled":true}
Why is it saying
"se:vncEnabled":true
? And also why is it saying"se:noVncPort":7900
for that matter?Furthermore if I go to the sessions page (http://localhost:4444/ui/#/sessions) then I can see a camera/video icon next to my session to launch the VNC viewer. If I click this it doesn't work but I would expect that this icon/button should not be there at all.
Have I managed to disable VNC or not? Am I saving resources or not? Do I need to set START_VNC and START__NO_VNC too? Its just unclear and doesn't fill me with confidence that it is doing what I want it to.
As well as the variables above do I also need to set SE_START_XVFB=false? If I do then I get catastrophic issues so assume not.
Command used to start Selenium Grid with Docker (or Kubernetes)
Relevant log output
Operating System
Ubuntu 20.04
Docker Selenium version (image tag)
4.23.0-20240727
Selenium Grid chart version (chart version)
No response
The text was updated successfully, but these errors were encountered: