Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Allow to overwrite SE_NODE_STEREOTYPE #1665

Closed
schmetzyannick opened this issue Aug 30, 2022 · 4 comments
Closed

[🚀 Feature]: Allow to overwrite SE_NODE_STEREOTYPE #1665

schmetzyannick opened this issue Aug 30, 2022 · 4 comments

Comments

@schmetzyannick
Copy link
Contributor

Feature and motivation

We wanted to set an applicationName in the stereotype of the node. Currentry it seems that the env variable will be overwritten, no matter what is set by the user:

SE_NODE_STEREOTYPE="{\"browserName\": \"${SE_NODE_BROWSER_NAME}\", \"browserVersion\": \"${SE_NODE_BROWSER_VERSION}\", \"platformName\": \"Linux\"}"

It would be great if we had the possibility to set this variable.

Usage example

Would provide a possibility to perform this:
https://www.selenium.dev/documentation/grid/configuration/toml_options/#setting-custom-capabilities-for-matching-specific-nodes

@diemol
Copy link
Member

diemol commented Aug 30, 2022

Would you like to send a pull request for this?

@schmetzyannick
Copy link
Contributor Author

Sure

@schmetzyannick
Copy link
Contributor Author

Done, testing it now: #1666

@diemol
Copy link
Member

diemol commented Sep 9, 2022

PR was merged

@diemol diemol closed this as completed Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants