[WIP] Check compatible optional dependency versions #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this:
This draft PR addresses #709 and adds checks for compatibility of optional dependencies in
import_optional
. Note that at the moment this functionality just checks that the correct submodels are present in the imported dependency. This solves the issue described in #709 where Shap throws an error on account of the version installed in Kaggle having an incompatible module structure.Todo:
Open Questions:
Should we be checking the version compatibility explicitly instead?