Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnchorBase test updates following coverage update #917

Closed
jklaise opened this issue Apr 26, 2023 · 1 comment
Closed

AnchorBase test updates following coverage update #917

jklaise opened this issue Apr 26, 2023 · 1 comment
Assignees
@RobertSamoilescu

Comments

@jklaise
Copy link
Contributor

jklaise commented Apr 26, 2023 •
edited
Loading

It seems that following #915 some tests need updating: https://github.com/SeldonIO/alibi/actions/runs/4810474219/jobs/8563144529

Edit: I've reverted #915, a new PR should be open with the changes + fixes to tests. We may need to consider why the original tests thought it's important that coverage change should be checked during a call to draw_samples @RobertSamoilescu.
@jklaise jklaise changed the title AnchorBase test updates following AnchorBase test updates following coverage update Apr 26, 2023
@jklaise
Copy link
Contributor Author

jklaise commented Apr 28, 2023

Closed via #919.

@jklaise jklaise closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertSamoilescu RobertSamoilescu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jklaise @RobertSamoilescu