From 7e9ebc5ad7eafd8fb95250a6757c0eb6f44d0df9 Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Thu, 29 Aug 2024 12:20:51 +0300 Subject: [PATCH 1/4] chore: hideReaderControls when mode is Sheet --- static/js/ReaderPanel.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/static/js/ReaderPanel.jsx b/static/js/ReaderPanel.jsx index 2a287473c3..32730d4a41 100644 --- a/static/js/ReaderPanel.jsx +++ b/static/js/ReaderPanel.jsx @@ -1058,6 +1058,7 @@ class ReaderPanel extends Component { const hideReaderControls = ( this.state.mode === "TextAndConnections" || + this.state.mode === "Sheet" || this.state.menuOpen || this.props.hideNavHeader ); From a0a5400588f63f29257828d6a121b529b135ca28 Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Tue, 10 Sep 2024 08:41:47 +0300 Subject: [PATCH 2/4] chore: headerHasBoxShadow when mode is Sheet --- static/js/ReaderApp.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/js/ReaderApp.jsx b/static/js/ReaderApp.jsx index 7476e5a041..5b84d95b9e 100644 --- a/static/js/ReaderApp.jsx +++ b/static/js/ReaderApp.jsx @@ -2063,7 +2063,7 @@ toggleSignUpModal(modalContentKind = SignUpModalKind.Default) { // Header should not show box-shadow over panels that have color line const menuOpen = this.state.panels?.[0]?.menuOpen; const hasColorLine = [null, "book toc", "sheets", "sheets meta"]; - const headerHasBoxShadow = hasColorLine.indexOf(menuOpen) === -1 || !this.props.multiPanel; + const headerHasBoxShadow = hasColorLine.indexOf(menuOpen) === -1 || !this.props.multiPanel || this.state.panels?.[0]?.mode === "Sheet"; // Header is hidden on certain mobile panels, but still rendered so the mobileNavMenu can be opened const hideHeader = !this.props.multiPanel && !this.state.headerMode && (!menuOpen || menuOpen === "text toc"); const header = ( From b17643d7e6eab4b543667f93d7f538528a5846f5 Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Sun, 22 Sep 2024 13:41:07 +0300 Subject: [PATCH 3/4] chore: fix bad spelling of directory --- static/js/ReaderPanel.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/js/ReaderPanel.jsx b/static/js/ReaderPanel.jsx index 77946e77b7..c46ed174fc 100644 --- a/static/js/ReaderPanel.jsx +++ b/static/js/ReaderPanel.jsx @@ -42,9 +42,9 @@ import { ToggleSet, InterfaceText, EnglishText, HebrewText, SignUpModal, } from './Misc'; import {ContentText} from "./ContentText"; -import SheetsWithRefPage from "./Sheets/SheetsWithRefPage"; +import SheetsWithRefPage from "./sheets/SheetsWithRefPage"; import {ElasticSearchQuerier} from "./ElasticSearchQuerier"; -import SheetsHomePage from "./Sheets/SheetsHomePage"; +import SheetsHomePage from "./sheets/SheetsHomePage"; class ReaderPanel extends Component { From dab6fa7520d1fd3fd9a4a136beddb78f3d04e188 Mon Sep 17 00:00:00 2001 From: stevekaplan123 Date: Thu, 28 Nov 2024 15:35:42 +0200 Subject: [PATCH 4/4] chore: Sheet should appear as menu instead of items --- static/css/s2.css | 1 + static/js/ReaderPanel.jsx | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/static/css/s2.css b/static/css/s2.css index b016bf6c9d..c0aaab0265 100644 --- a/static/css/s2.css +++ b/static/css/s2.css @@ -9951,6 +9951,7 @@ span.purim-emoji img{ /* Sheets */ .sheetsInPanel { + font-size: 62.5%; overflow-y: scroll; overflow-x: hidden; height: 100%; diff --git a/static/js/ReaderPanel.jsx b/static/js/ReaderPanel.jsx index 049feb573e..3f3fdff76a 100644 --- a/static/js/ReaderPanel.jsx +++ b/static/js/ReaderPanel.jsx @@ -685,8 +685,7 @@ class ReaderPanel extends Component { ); } if (this.state.mode === "Sheet") { - items.push( - - ); + />; } if (this.state.mode === "Connections" || this.state.mode === "TextAndConnections") {