-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Improve embit_utils
test coverage
#343
Comments
I'd played with this https://gist.github.com/jdlcdl/79392ec1417863c49498815edc7e01bd a while back, so I'll look to continuing towards more coverage. |
simply adding that file to a new branch and running coverage again brings the report to:
...but I have no intention of leaving it like this. This was originally my attempt at exhaustive coverage of a single function. Seeing all that has evolved in your latest testing sprint, I'll convert my style from test functions to test classes and methods and do my best to adopt similar style to remain consistent with the rest of the tests. To state my intentions on unit-testing... because this particular example is crazy-monotonous and very-boring to maintain, they are:
In a ideal/perfect unit-tested project... I'd like to believe that an entire codebase could be deleted, and then unit-test files could be divied-out to many different devs and they'd all recreate (or port to another language) the same working codebase in record time. |
Now that #342 has been merged, this should be a pretty straightforward PR.
Current coverage report:
I recommend writing tests into a new tests/test_embit_utils.py file.
The text was updated successfully, but these errors were encountered: