feat(SebmGoogleMapPolygon): support for polygon usage #652
Conversation
Modelled after polyline directive. Additional: - add containsLocation method to api-wrapper for interaction between points and polygons Resolves #615
Missing in the last commit
Missing in the last commit
Fix formatting errors
|
@gorango Thank you, this looks great! I will review it in the next few days |
| * | ||
| * ### Example | ||
| * ```typescript | ||
| * import {Component} from 'angular2/core'; |
There was a problem hiding this comment.
This code is outdated. Please use the Angular 2.0.0 way here
| * | ||
| * @Component({ | ||
| * selector: 'my-map-cmp', | ||
| * directives: [SebmGoogleMap, SebmGooglePolygon], |
| 'zIndex', | ||
| ], | ||
| outputs: [ | ||
| 'lineClick', 'lineDblClick', 'lineDrag', 'lineDragEnd', 'lineMouseDown', 'lineMouseMove', |
There was a problem hiding this comment.
change names to polyClick, polyDblClick, ...
| return; | ||
| } | ||
|
|
||
| let options: {[propName: string]: any} = {}; |
There was a problem hiding this comment.
can you add move this code to a private method called _updatePolygonOptions
no need to store reference to options..
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
change line -> poly change polyline -> polygon
|
There were the following issues with your Pull Request
Contribution guidelines are available at https://github.com/SebastianM/angular2-google-maps/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Hello @SebastianM & @gorango can you get it merged? Would love to use this feature :) |
|
Could we merge this please? Our deadline is in 3 hours :D |
|
@gorango merged, thanks! Modified a few lines. |
containsLocationmethod to api-wrapper for interactionbetween points and polygons
Resolves #615