Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MarkerManager): Set a visible option to marker. #524

Closed
wants to merge 1 commit into from

Conversation

TSHiYK
Copy link
Contributor

@TSHiYK TSHiYK commented Jul 22, 2016

No description provided.

@sebholstein
Copy link
Owner

@TSHiYK thank you! can you squash the commits to one?

@TSHiYK
Copy link
Contributor Author

TSHiYK commented Aug 8, 2016

@SebastianM Done!

@@ -74,6 +74,11 @@ export class SebmGoogleMapMarker implements OnDestroy, OnChanges, AfterContentIn
iconUrl: string;

/**
* If true, the marker is visible
*/
visible: boolean;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, here the same thing: Please set the default value of this to true.

@TSHiYK
Copy link
Contributor Author

TSHiYK commented Aug 8, 2016

Done! I set the default value to true.

sebholstein pushed a commit that referenced this pull request Aug 9, 2016
sebholstein pushed a commit that referenced this pull request Aug 9, 2016
sebholstein pushed a commit that referenced this pull request Aug 9, 2016
sebholstein pushed a commit that referenced this pull request Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants