feat(MarkerManager): set an opacity to marker. #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSHiYK
changed the title
|
@TSHiYK Looking good! 👍 |
|
@TSHiYK thanks! can you change the commit message from fix to feat? Than we can merge it! good job. |
TSHiYK
changed the title
|
@SebastianM Thanks for reply. I fixed the commit message. |
| @@ -79,6 +79,11 @@ export class SebmGoogleMapMarker implements OnDestroy, OnChanges, AfterContentIn | |||
| openInfoWindow: boolean = true; | |||
|
|
|||
| /** | |||
| * The marker's opacity between 0.0 and 1.0. | |||
| */ | |||
| opacity: number; | |||
There was a problem hiding this comment.
can we set the default here?: opacity: number = 1;
|
Sorry, found one more little thing. When the default is 1, we can merge it. |
|
@SebastianM Done! |
Closed
|
Any way to animate this opacity other than setInterval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.