Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleMapMarker logtitude spelling mistake #163

Closed
tuqtran opened this issue Feb 25, 2016 · 6 comments
Closed

GoogleMapMarker logtitude spelling mistake #163

tuqtran opened this issue Feb 25, 2016 · 6 comments

Comments

@tuqtran
Copy link

tuqtran commented Feb 25, 2016

I work with version 0.8.0 and found that in google-map-marker.ts it have a wrong spelling detect for longtitude value.

ngOnChanges(changes: {[key: string]: SimpleChange}) {
...
if (changes['latitude'] || changes['logitude']) {
this._markerManager.updateMarkerPosition(this);
}

It will block the map marker change when user change only the longtitude value.

Could you please fix it?

@sebholstein
Copy link
Owner

@tranquoctu1988 thanks for reporting. this is indeed a bug. will fix this with 0.8.1

sebholstein added a commit that referenced this issue Feb 25, 2016
Longitude changes were not considered.

fixes #163
closes #167
@ldtung
Copy link

ldtung commented Feb 26, 2016

Hi
Is it updated with npm install yet?

@sebholstein
Copy link
Owner

@ldtung no, but you can build the latest version:

git clone https://github.com/SebastianM/angular2-google-maps
cd angular2-google-maps
npm install
./node_modules/.bin/typings install
./node_modules/.bin/gulp build

and then use the dist/angular2-google-maps.js file.

@ldtung
Copy link

ldtung commented Feb 28, 2016

Thanks. but when do you plan to put on npm? we need to install directly from it to support upgrade later?

@sebholstein
Copy link
Owner

@ldtung it's now available in v0.8.1

@ldtung
Copy link

ldtung commented Mar 2, 2016

Thanks. I checked it out

2016-03-02 2:50 GMT+07:00 Sebastian Müller [email protected]:

@ldtung https://github.com/ldtung it's now available in v0.8.1


Reply to this email directly or view it on GitHub
#163 (comment)
.

Le Duc Tung
IT Faculty - University of Science, HCM

Phone : 0984310501
Yahoo: ldtung_it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants