-
Notifications
You must be signed in to change notification settings - Fork 817
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(LazyMapsAPILoader): use OpaqueTokens for globs
The Interfaces Window and Document seem not to work in all enviroments, so we now use OpaqueTokens to make sure that it's working in all cases. Fixes #436 Closes #441
- Loading branch information
1 parent
e7426c5
commit 78daae0
Showing
4 changed files
with
18 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import {Provider, provide} from '@angular/core'; | ||
import {OpaqueToken, Provider, provide} from '@angular/core'; | ||
|
||
export const WINDOW_GLOBAL = new OpaqueToken('angular2-google-maps window_global'); | ||
export const DOCUMENT_GLOBAL = new OpaqueToken('angular2-google-maps document_global'); | ||
|
||
export const BROWSER_GLOBALS_PROVIDERS: Provider[] = | ||
[provide(Window, {useValue: window}), provide(Document, {useValue: document})]; | ||
[provide(WINDOW_GLOBAL, {useValue: window}), provide(DOCUMENT_GLOBAL, {useValue: document})]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78daae0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! hotfix or new milestone, PLS