Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order of operations in __plot2D #26

Open
abmantz opened this issue Sep 8, 2020 · 1 comment
Open

order of operations in __plot2D #26

abmantz opened this issue Sep 8, 2020 · 1 comment

Comments

@abmantz
Copy link

abmantz commented Sep 8, 2020

I see in __plot2D that the Gaussian smoothing is done after normalizing and finding the contour levels to show. Seems like it would be more consistent to use the smoothed density estimate throughout. In particular, if the smoothing is not conservative, the contour levels may be thrown off noticeably at ~2 sigma and higher.

@SebastianBocquet
Copy link
Owner

Thanks Adam, that is a very sensible suggestion. In hindsight I guess there's no good reason to have done the inverse. Let me look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants