Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

nsc-events-android-5-229-add-sign-out-button #230

Closed
wants to merge 5 commits into from

Conversation

nhapham03
Copy link

Resolves #229

@nhapham03 nhapham03 added enhancement New feature or request help wanted Extra attention is needed Sprint 5 labels Apr 18, 2024
@nhapham03 nhapham03 self-assigned this Apr 18, 2024
@nhapham03 nhapham03 changed the title nsc-events-android _ 5 _ 229 _ add-sign-out-button nsc-events-android-5-229-add-sign-out-button Apr 18, 2024
@LilithLucifer3x6 LilithLucifer3x6 marked this pull request as ready for review April 20, 2024 01:55
Copy link
Contributor

@LilithLucifer3x6 LilithLucifer3x6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It functions as I would epect.

@Robel-003
Copy link
Contributor

Is this PR for the web application? I noticed the user story related to this shows an image for the web application

@heosman
Copy link
Contributor

heosman commented Apr 24, 2024

@nhapham03 I do not see any changes in the files for this PR.

@Robel-003 Not sure why that image was shown, but this PR should be for the android app.

@MuhammadNSC
Copy link
Contributor

I dont see this changes in the NSC android app. The image shown shows that the sign-out function was done to the NSC nextjs app

@LilithLucifer3x6 LilithLucifer3x6 dismissed their stale review April 26, 2024 02:13

PR wasn't for the app I was checking

@JesseCaddell
Copy link

closing due to lack of engagement. 5 month old PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed Sprint 5
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sign Out Functionality: Should be added to the nav bar after user has logged in
6 participants