Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Shellcheck-action workflow #71

Closed
wants to merge 1 commit into from
Closed

Conversation

mukul-seagate11
Copy link
Contributor

Signed-off-by: Mukul Malhotra [email protected]

Shellcheck-action workflow

Signed-off-by: Mukul Malhotra <[email protected]>
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add integration to a branch for triggering, as well as target the integration branch as the merge target branch for the PR (instead of main)?

Otherwise, it looks good.

@keithpine
Copy link
Contributor

I already have an open PR #58, which handles checking pull requests and pushes to both branches, and temporarily disables errors until we clean up all the failures. I'll update that to use the action fork, and add the copyright notice to the workflow file.

@keithpine keithpine closed this Feb 1, 2022
@mukul-seagate11 mukul-seagate11 deleted the mukul-EOS-28082-patch2 branch February 2, 2022 04:14
@mukul-seagate11 mukul-seagate11 restored the mukul-EOS-28082-patch2 branch February 2, 2022 04:14
@mukul-seagate11 mukul-seagate11 deleted the mukul-EOS-28082-patch2 branch February 2, 2022 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants