Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-32842: Remove unused Control persistence settings #345

Merged
merged 1 commit into from
Jul 27, 2022
Merged

CORTX-32842: Remove unused Control persistence settings #345

merged 1 commit into from
Jul 27, 2022

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented Jul 27, 2022

Description

Now that Control uses emptyDir, we don't need any Chart persistent values, and we don't need to create the PVC. Prior to this change, a PVC was created that persisted in a Pending state.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-32842
  • This change is related to an issue: #

How was this tested?

Deployed successfully. Examined PVCs and no more pending Control PVC. Status script successful.

Additional information

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

  • The image fields in solution.example.yaml have been updated to use the required versions.
  • The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@cla-bot cla-bot bot added the cla-signed label Jul 27, 2022
Now that Control uses `emptyDir`, there's no need for persistence Chart
values nor a reason to create a PVC.

Signed-off-by: Keith Pine <[email protected]>
@keithpine keithpine changed the title CORTX-32842: Remove Control PVC CORTX-32842: Remove unused Control persistence settings Jul 27, 2022
@keithpine keithpine marked this pull request as ready for review July 27, 2022 17:59
@keithpine keithpine requested a review from a team as a code owner July 27, 2022 17:59
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@osowski osowski merged commit 143cd66 into Seagate:integration Jul 27, 2022
@keithpine keithpine deleted the CORTX-32842_no-pvc branch July 27, 2022 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants