Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Deploy with custom Chart values #334

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Deploy with custom Chart values #334

merged 1 commit into from
Jul 20, 2022

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented Jul 19, 2022

Description

Specify a custom values.yaml file when using the deployment script to add or override calculated values. This makes it possible to configure things not supported by solution.yaml, for example, enabling the Consul Web UI by default.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

How was this tested?

❯ cat myvalues.yaml 
consul:
  ui:
    enabled: true

Deploy with the above values file, and I can see the Consul UI is enabled.

Specify a non-existent file, and see an error is report and the deploy script exits before installing.

Specify a blank env var, or none at all, and notice a normal, unmodified deployment (no Consul UI).

Additional information

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

  • The image fields in solution.example.yaml have been updated to use the required versions.
  • The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered README.md

@cla-bot cla-bot bot added the cla-signed label Jul 19, 2022
Specify a custom values.yaml file when using the deployment script to add
or override calculated values.

Signed-off-by: Keith Pine <[email protected]>
@keithpine keithpine marked this pull request as ready for review July 19, 2022 23:54
@keithpine keithpine requested a review from a team as a code owner July 19, 2022 23:54
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit 9c7d57d into Seagate:integration Jul 20, 2022
@keithpine keithpine deleted the deploy-custom-values branch July 20, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants