Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-30140: Zookeeper managed as cortx Helm Chart dependency #236

Merged
merged 2 commits into from
May 9, 2022
Merged

CORTX-30140: Zookeeper managed as cortx Helm Chart dependency #236

merged 2 commits into from
May 9, 2022

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented May 6, 2022

Description

Add Zookeeper as a dependency to the new CORTX chart. In this case, Zookeeper is already a dependency of Kafka, so we let the Kafka chart manage it. Follow up to PRs #230 and #233.

Breaking change

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-30140

CORTX image version requirements

How was this tested?

Deployed a new release using this PR. Performed basic I/O.

Tested backwards compatibility by deploying a release prior to this PR. Then ran all of the updated utility scripts against that deployment (although, see Additional information).

Additional information

The status-cortx-cloud.sh script will report a failure for Zookeeper Cluster IP services when running against an earlier deployment, since the names of the services have changed. I don't consider this a breaking change, since the status script should reflect what is expected based on how it is supposed to be deployed with the current version.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered charts/cortx/README.md

@keithpine keithpine requested a review from a team as a code owner May 6, 2022 23:29
@cla-bot cla-bot bot added the cla-signed label May 6, 2022
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit 4f5cbf4 into Seagate:integration May 9, 2022
@keithpine keithpine deleted the CORTX-30140_subcharts-zookeeper branch May 9, 2022 22:19
@keithpine keithpine added this to the v0.6.0 milestone Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants