Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-31239: Support variable timeout values in deploy-cortx-cloud.sh #234

Conversation

walterlopatka
Copy link
Contributor

@walterlopatka walterlopatka commented May 5, 2022

Description

There is a "wait" after each of the cortx helm charts are deployed. This wait is guarded by a timeout. Prior to this change the timeout values were hard-coded.

With this change in environment variable can override the timeout value. The supported environment variables are:

  • CORTX_DEPLOY_CONTROL_TIMEOUT (default 300s)
  • CORTX_DEPLOY_DATA_TIMEOUT (default 300s)
  • CORTX_DEPLOY_SERVER_TIMEOUT (default 300s)
  • CORTX_DEPLOY_HA_TIMEOUT (default 120s)

This value is passed directly to kubectl wait --timeout=${TIMEOUT}

This is being added so that CORTX developers can work around the previously hard-coded timeouts as needed.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-31239

How was this tested?

Tested locally:

  • Set short timeouts for CORTX_DEPLOY_CONTROL_TIMEOUT and CORTX_DEPLOY_HA_TIMEOUT and verified that they took effect
  • Ran with standard timeouts to verify no change

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered README.md

There is a "wait" after each of the cortx helm charts
are deployed.  This wait is guarded by a timeout.
Prior to this change the timeout values were hard-coded.

With this change in environment variable can override
the timeout value.  The supported environment
variables are:

  CORTX_DEPLOY_CONTROL_TIMEOUT (default 300s)
  CORTX_DEPLOY_DATA_TIMEOUT (default 300s)
  CORTX_DEPLOY_SERVER_TIMEOUT (default 300s)
  CORTX_DEPLOY_HA_TIMEOUT (default 120s)

This value is passed directly to "kubectl wait --timeout=${TIMEOUT}"

Signed-off-by: Walter Lopatka <[email protected]>
@cla-bot cla-bot bot added the cla-signed label May 5, 2022
Signed-off-by: Walter Lopatka <[email protected]>
Signed-off-by: Walter Lopatka <[email protected]>
Signed-off-by: Walter Lopatka <[email protected]>
@walterlopatka walterlopatka marked this pull request as ready for review May 5, 2022 21:29
@walterlopatka walterlopatka requested a review from a team as a code owner May 5, 2022 21:29
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@osowski osowski merged commit 7f879c1 into Seagate:integration May 5, 2022
@walterlopatka walterlopatka deleted the CORTX-31239_adjustable_deploy_timeouts branch May 5, 2022 21:34
@walterlopatka walterlopatka added this to the v0.5.0 milestone May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants