Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-31043: Exit on helm failure #225

Conversation

walterlopatka
Copy link
Contributor

Description

This change causes the deploy script to exit immediately if any helm install command fails.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-31043
  • This change is related to an issue: #

How was this tested?

This was tested by:

  • Running ./deploy-cortx-cloud.sh specifying namespace with invalid characters ("Bad-namespace!")
  • Verified that deploy works through normal path

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@walterlopatka walterlopatka requested a review from a team as a code owner April 27, 2022 14:13
@cla-bot cla-bot bot added the cla-signed label Apr 27, 2022
Copy link
Contributor

@keithpine keithpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now.

Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@walterlopatka walterlopatka merged commit 69b6f32 into Seagate:integration Apr 27, 2022
@walterlopatka walterlopatka deleted the CORTX-31043_exit_on_helm_failure branch April 27, 2022 14:44
@johnbent
Copy link
Contributor

Just for future reference, "This change fixes an issue: CORTX-31043" is referring to https://jts.seagate.com/browse/CORTX-31043

@walterlopatka walterlopatka added this to the v0.5.0 milestone May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants