Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

EOS-27447 - clusterip svc for hax #100

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

osowski
Copy link
Contributor

@osowski osowski commented Feb 11, 2022

Implements a new ClusterIP Service for HAX-enabled Data & Server Pods.

@osowski osowski added the enhancement New feature or request label Feb 11, 2022
@osowski osowski requested a review from a team February 11, 2022 16:06
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. As I ask in an inline comment, do you need to remove function deleteCortxServices() in destroy-cortx.cloud.sh (since you removed function deployCortxServices())?

Copy link
Contributor

@keithpine keithpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't be any problem for me to incorporate this into my ConfigMap changes. 👍

@osowski
Copy link
Contributor Author

osowski commented Feb 11, 2022

@osowski osowski merged commit b96b9a1 into integration Feb 11, 2022
@osowski osowski added this to the v0.0.22 milestone Feb 15, 2022
@osowski osowski self-assigned this Feb 15, 2022
@osowski osowski deleted the EOS-27447-clusterip_svc_for_hax branch February 22, 2022 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants