Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout submission #65

Open
ndahlquist-cc opened this issue Dec 10, 2015 · 2 comments
Open

Checkout submission #65

ndahlquist-cc opened this issue Dec 10, 2015 · 2 comments
Assignees
@dHofstede

Comments

@ndahlquist-cc
Copy link
Member

should not be able to submit without the user having a billing address and shipping address entered.
Unsure about checkboxes for hardcopy and download. Can checkout without any checkboxes checked, is this intended?
@BlackthornYugen
Copy link
Member

I was the one who made checkout ignore checkboxes when I implemented Stripe. My understanding was that if you didn't want to buy something you would remove it from your cart before hitting checkout. The price needs to be the same on the client's request to stripe and the server's processing of the payment. Having a moving price target looked like to much complexity to add to make our deadline.

@dHofstede
Copy link
Contributor

I have a pull request with the fix to the address issue, just waiting to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dHofstede dHofstede

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BlackthornYugen @ndahlquist-cc @dHofstede