Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn column() also handle enum type #960

Closed
tyt2y3 opened this issue Aug 11, 2022 · 1 comment · Fixed by #973
Closed

fn column() also handle enum type #960

tyt2y3 opened this issue Aug 11, 2022 · 1 comment · Fixed by #973
Assignees
@billy1624
Milestone
0.10.x

Comments

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 11, 2022

Looks like we are doing some magic inside fn column_list(&self) -> Vec<SimpleExpr> { of select.rs.
It should also be possible to do the same in fn column() ? @billy1624
Then it will be transparent to the user?

Originally posted by @tyt2y3 in #843 (comment)
@tyt2y3 tyt2y3 changed the title fn column also handle enum type fn column() also handle enum type Aug 11, 2022
@billy1624
Copy link
Member

Good call!

@billy1624 billy1624 moved this to Triage in SeaQL Dev Tracker Aug 15, 2022
@billy1624 billy1624 moved this from Triage to In Progress in SeaQL Dev Tracker Aug 15, 2022
@billy1624 billy1624 self-assigned this Aug 15, 2022
@billy1624 billy1624 mentioned this issue Aug 15, 2022
Merged
2 tasks
@billy1624 billy1624 moved this from In Progress to Review in SeaQL Dev Tracker Aug 16, 2022
@billy1624 billy1624 added this to the 0.10.x milestone Aug 24, 2022
@billy1624 billy1624 moved this from Review to Done in SeaQL Dev Tracker Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
0.10.x
Development

Successfully merging a pull request may close this issue.

Rewrite enum and text casting SeaQL/sea-orm
2 participants
@tyt2y3 @billy1624