Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit on Existing PRs #13

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

Samq64
Copy link
Member

@Samq64 Samq64 commented Dec 15, 2024

Resolves #12

I tested the logic locally with the push and node lines commented out.

@Samq64 Samq64 requested a review from Hans5958 December 17, 2024 13:55
Copy link
Member

@Hans5958 Hans5958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try this.

@Hans5958 Hans5958 merged commit b348b83 into ScratchAddons:main Dec 19, 2024
@Samq64 Samq64 deleted the commit-existing-pr branch December 19, 2024 01:37
@Hans5958
Copy link
Member

If this works well enough, we can remove the date from the title.

@Samq64
Copy link
Member Author

Samq64 commented Dec 19, 2024

The date could be added to the commit messages instead.

@Hans5958
Copy link
Member

Huh, it's failing.

https://github.com/ScratchAddons/ScratchAddons/actions/runs/12423492030/job/34687093816

Would you like to take a look?

@Samq64
Copy link
Member Author

Samq64 commented Dec 20, 2024

I forgot to run git fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit on exsisting PR
2 participants