Include hidden files in packer action #8010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samq64
added
the
scope: ci
DNin01
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
This will work fine, but I think a better approach would be to not have hidden files in the first place.
Consider merging ScratchAddons/packer-script#2 and #8012 instead.
|
Would you guys prefer this or the other solution by @DNin01? |
|
I haven't tested it yet but I like @DNin01's solution better. |
|
Superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7134 (comment)
Tells upload-artifact to explicitly include dotfiles since it doesn't by default anymore. See actions/upload-artifact#602.
Tests
I successfully ran the action on my fork and loaded the extension into Chromium.