Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Generated changelog empty #16

Closed
jnorkus opened this issue Nov 16, 2020 · 2 comments · Fixed by #22
Closed

Generated changelog empty #16

jnorkus opened this issue Nov 16, 2020 · 2 comments · Fixed by #22
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jnorkus
Copy link

jnorkus commented Nov 16, 2020

I can't get it to work with the provided example and I think I know why.

From lob/generate-changelog documentation:

This is meant to be used so that for every patch, minor, or major version, you update the changelog prior to running npm version so that the git tag contains the commit that updated both the changelog and version.

If the action is triggered by a tag push it is already too late to generate the changelog.

@ScottBrenner ScottBrenner added bug Something isn't working documentation Improvements or additions to documentation labels Nov 16, 2020
@ScottBrenner
Copy link
Owner

Whoops, please open a pull request with a fix!

@jnorkus
Copy link
Author

jnorkus commented Nov 18, 2020

In the end I solved it by implementing the recommended flow, i.e. generating the changelog client side. This means I'm no longer using the action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
2 participants