Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fee PER BYTE Field On Send Transaction Form #81

Open
apbendi opened this issue Aug 14, 2020 · 3 comments
Open

Add Fee PER BYTE Field On Send Transaction Form #81

apbendi opened this issue Aug 14, 2020 · 3 comments

Comments

@apbendi
Copy link
Member

apbendi commented Aug 14, 2020

Issue 6.1

  • Add a "fee" field to the send transaction form below "amount" that defaults to 1,000 sompis
  • Display in KSP Units
  • Allow user to edit this fee, and use the value provided in the transaction
@apbendi apbendi changed the title Add Fee Field On Send Transaction Form Add Fee PER BYTE Field On Send Transaction Form Aug 17, 2020
@apbendi
Copy link
Member Author

apbendi commented Aug 17, 2020

Update: the field is actually going to be a FEE PER BYTE field, not the final fee. The final fee get's calculated by multiplying the fee per byte they've entered by the size of the tx.

let there be a default (the minimum allowed) tx fee per byte. Let the user change the tx fee per byte. The final fee will then be displayed on the next page as the set fee per byte x the tx byte size. So in other words, the user is selecting the fee per byte, not the total fee.

@wildmolasses
Copy link
Contributor

wildmolasses commented Aug 17, 2020

from chat:

wildmolasses
Hi @jablonx , is size of kaspa tx equal to size in bytes of rawTransaction? i.e. 1 byte for every 2 characters of hex encoded tx?
jablonx
should be. and it's 1 sompi per byte

@ey51
Copy link

ey51 commented Aug 20, 2020

Current state is that the fee is a hardcoded fee per byte.
Adding a fee per byte field in the tx send form preloaded with the placeholder default 1 sompi per byte could be useful for testnet (we can overload the mempool with txgen, and then use the fee per byte field to test mining tx selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants