Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream changes to Aave v3 to make it more extensible #16

Closed
davidlaprade opened this issue Nov 16, 2022 · 2 comments
Closed

Upstream changes to Aave v3 to make it more extensible #16

davidlaprade opened this issue Nov 16, 2022 · 2 comments
Assignees
@davidlaprade
Labels
enhancement New feature or request

Comments

@davidlaprade
Copy link
Contributor

davidlaprade commented Nov 16, 2022 •
edited
Loading

We already did this here: aave/aave-v3-core#726

Other functions we should update:
@davidlaprade davidlaprade added the enhancement New feature or request label Nov 16, 2022
@davidlaprade davidlaprade mentioned this issue Nov 16, 2022
Merged
@davidlaprade davidlaprade mentioned this issue Dec 20, 2022
Merged
@davidlaprade davidlaprade self-assigned this Dec 21, 2022
@davidlaprade
Copy link
Contributor Author

I realized this morning that we don't need to make aToken.burn() public to do what we want. See ffc2867 for a better solution that didn't require any Aave changes.

I pushed a PR to make the other two changes: aave/aave-v3-core#774

@apbendi
Copy link
Member

apbendi commented Jan 3, 2023

@davidlaprade should we close this now that our PR has been merged by Aave?

@apbendi apbendi closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlaprade davidlaprade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apbendi @davidlaprade