Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull-request checklist needs a revamp #3453

Closed
5 tasks
pp-mo opened this issue Oct 7, 2019 · 2 comments
Closed
5 tasks

Pull-request checklist needs a revamp #3453

pp-mo opened this issue Oct 7, 2019 · 2 comments
Assignees

Comments

@pp-mo
Copy link
Member

pp-mo commented Oct 7, 2019

Problems spotted :

  1. "Iris tests may be run with python setup.py test " -- is this still true, or is there a bette way ?
  2. "There is a python module for checking pep8 compliance: python-pep8" -- should now be referring to flake8
  3. "the files ./conda-requirements.yml and ./minimal-conda-requirements.yml are used to define the software environments" -- now uses combined requirements process in iris/requirements
  4. "test-images-scitools is a github project containing reference plot images" -- has moved
  5. "see Graphics tests" -- docs-page still incomplete https://scitools.org.uk/iris/docs/latest/developers_guide/tests.html#graphics-tests
@rcomer
Copy link
Member

rcomer commented Jan 9, 2020

I was rummaging in the image tests today (as you do) and noticed there seems to be an option for displaying the figures that you are testing:

if MPL_AVAILABLE and "-d" in sys.argv:
sys.argv.remove("-d")
plt.switch_backend("tkagg")
_DISPLAY_FIGURES = True

This would be useful information to have in the proposed new How To Run the Tests section.

@tkknight tkknight self-assigned this Sep 8, 2020
@tkknight
Copy link
Contributor

Fixed by #3852 and other earlier PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants