separate out reactants and products for new SBML version #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 85.89% 86.25% +0.35%
==========================================
Files 1 1
Lines 156 160 +4
==========================================
+ Hits 134 138 +4
Misses 22 22
Continue to review full report at Codecov.
|
|
@paulflang just want ur double check that this shouldn't mess with any of the test-suite verifications right |
|
I do not see a reason why cases in the test suite that passed before should break now. But I cannot guarantee that. I am wondering if it would make sense to add checks for regression in SBMLBioModelsRepository.jl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wont pass until new SBML is released.
all tests pass locally