Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip reactions without subs and prods #25

Merged
merged 3 commits into from
Aug 1, 2021
Merged

skip reactions without subs and prods #25

merged 3 commits into from
Aug 1, 2021

Conversation

paulflang
Copy link
Member

No description provided.

@paulflang paulflang requested a review from anandijain July 31, 2021 21:29
@codecov
Copy link

codecov bot commented Jul 31, 2021

Codecov Report

Merging #25 (9f3e077) into main (5005264) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   84.96%   85.16%   +0.19%     
==========================================
  Files           1        1              
  Lines         153      155       +2     
==========================================
+ Hits          130      132       +2     
  Misses         23       23              
Impacted Files Coverage Δ
src/reactionsystem.jl 85.16% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5005264...9f3e077. Read the comment docs.

@anandijain
Copy link
Contributor

is there a test-suite case that this fixes? not exactly sure where this is needed. I'm sure it is though

@paulflang
Copy link
Member Author

yeah. it is case 01246.

@anandijain anandijain merged commit 60f56f6 into main Aug 1, 2021
@anandijain anandijain deleted the pl-fix_case01246 branch August 1, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants