remove String dispatches for MTK constructors #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas and I talked and these would be considered type piracy, even though there are no methods currently taking String in the main MTK repo, other packages may want to define their own
@paulflang I am also thinking that we want to remove the direct ODEProblem constructor, per this comment LCSB-BioCore/SBML.jl#40 (comment)
I think it makes more sense to just require them to use sth like
ODEProblem(ODESystem(readSBML(filename)))
.I haven't implemented that last point yet though