Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Tag new release? #75

Closed
crbinz opened this issue Sep 4, 2015 · 10 comments
Closed

Tag new release? #75

crbinz opened this issue Sep 4, 2015 · 10 comments

Comments

@crbinz
Copy link

crbinz commented Sep 4, 2015

Is it possible to tag a new release for this project? I've been using the new Runge-Kutta solver (particularly with the keyword arguments support), and it would help to have a version I can specify in my REQUIRE. Thanks.

@mauro3
Copy link
Contributor

mauro3 commented Sep 5, 2015

I think the idea was to tag a new release after the merge of the new R-K solver, maybe it was just forgotten?

@acroy
Copy link
Contributor

acroy commented Sep 7, 2015

The question is if we should tag it as v"0.3.0" or v"0.2.1" (v"0.2.0" points to the old implementation)?

@tomasaschan
Copy link
Contributor

The new solvers have changed the api, right? Then I think v0.3.0 is appropriate.

@acroy
Copy link
Contributor

acroy commented Sep 7, 2015

I think they haven't. For example, Mauro had to put in some effort to support those "scalar-like types" as we had them before.

@mauro3
Copy link
Contributor

mauro3 commented Sep 7, 2015

The interface of the low-level function changed somewhat:

function oderk_adapt{N,S}(fn, y0::AbstractVector, tspan, btab_::TableauRKExplicit{N,S};
                          reltol = 1.0e-5, abstol = 1.0e-8,
                          norm=Base.norm,
                          minstep=abs(tspan[end] - tspan[1])/1e18,
                          maxstep=abs(tspan[end] - tspan[1])/2.5,
                          initstep=0.,
                          points=:all
                          )

vs before

function oderkf(F, x0, tspan, p, a, bs, bp; reltol = 1.0e-5, abstol = 1.0e-8,
                                            norm=Base.norm,
                                            minstep=abs(tspan[end] - tspan[1])/1e9,
                                            maxstep=abs(tspan[end] - tspan[1])/2.5,
                                            initstep=0.)

For the exported functions this only adds points. For some reason ode23 is not exported anymore, however, this is probably a bug and should be fixed.

@acroy
Copy link
Contributor

acroy commented Sep 14, 2015

@mauro3 : I just added the export of ode23 which got lost somehow.

If there are no objections I will tag the current master as v"0.2.1" instead of v"0.3.0" since the API hasn't really changed.

@mauro3
Copy link
Contributor

mauro3 commented Sep 14, 2015

Yep, that sounds good.

@yuyichao
Copy link
Contributor

Is the tagging happenning? Would be nice to get rid of those annoy deprecation warnings...

@yuyichao
Copy link
Contributor

Given #76 (comment) I just went ahead and tagged 0.2.1

@mauro3
Copy link
Contributor

mauro3 commented Sep 19, 2015

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants