Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate stats handling #410

Closed
avik-pal opened this issue Apr 16, 2024 · 2 comments · Fixed by #437
Closed

Consolidate stats handling #410

avik-pal opened this issue Apr 16, 2024 · 2 comments · Fixed by #437
Assignees

Comments

@avik-pal
Copy link
Member

As pointed out by @oscardssmith, it would be good to store a centralized stats in the cache and update references to it instead of adding up the stats at the end.

Would probably make SciML/OrdinaryDiffEq.jl#2167 easier

@avik-pal avik-pal self-assigned this Apr 23, 2024
@oscardssmith
Copy link
Contributor

Also worth noting that I'm pretty sure that for the polyalgs, the stats are just wrong. They appear to only report the stats from the solver that it actually used: https://github.com/SciML/NonlinearSolve.jl/blob/b389d0e9e9e4a1ff4350a2cce824ec8a03310e53/src/default.jl#L184C9-L184C14.

@avik-pal
Copy link
Member Author

Yes that is an unfortunate decision I made. Previously we showed no stats but then I decided it is atleast worthwhile to get the stats for the oslver that worked. Using a reference to a top level stats object solves all of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants