Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inplace Problem Specification for Methods with size(residual) != size(u) #195

Closed
avik-pal opened this issue Jul 17, 2023 · 2 comments · Fixed by #203
Closed

Inplace Problem Specification for Methods with size(residual) != size(u) #195

avik-pal opened this issue Jul 17, 2023 · 2 comments · Fixed by #203

Comments

@avik-pal
Copy link
Member

Currently, for inplace problems the residual vector is determined by the size of the input u. This is not necessarily correct for problems that support overconstrained / underconstrained setups. For example:

fu = zero(u)
f(fu, u, p)

Could we potentially add a kwarg like residual_size which could be used to initialize this?

@ChrisRackauckas
Copy link
Member

I think it may just be best to just use jac_prototype for this?

@avik-pal
Copy link
Member Author

That seems like the proper solution. I will prototype this in NeuralBVP.jl and then port it over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants