Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrals is broken with SciMLBase v2.66.0 #259

Closed
MarcoRiggirello opened this issue Dec 5, 2024 · 2 comments
Closed

Integrals is broken with SciMLBase v2.66.0 #259

MarcoRiggirello opened this issue Dec 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@MarcoRiggirello
Copy link

Describe the bug 🐞

Version 2.66.0 of SciMLBase breaks Integrals.

Expected behavior

solve(IntegralProblem(...), ...) should give the solution

Minimal Reproducible Example 👇

Without MRE, we would only be able to help you to a limited extent, and attention to the issue would be limited. to know more about MRE refer to wikipedia and stackoverflow.

ENV["JULIA_PKG_SERVER_REGISTRY_PREFERENCE"] = "eager"

using Pkg

Pkg.Registry.update()

Pkg.activate(".")
Pkg.add(name="SciMLBase", version="2.66.0")
Pkg.add("Integrals")

using Integrals

f(x, p) = x * p
g = IntegralFunction(f)

prob = IntegralProblem(g, ([1,2], [3,4]), 1)
sol = solve(prob, HCubatureJL())

Error & Stacktrace ⚠️

ERROR: LoadError: type IntegralFunction has no field sys
Stacktrace:
 [1] getproperty(x::Function, f::Symbol)
   @ Base ./Base.jl:49
 [2] updated_u0_p(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}, u0::Nothing, p::Missing, t0::Nothing; interpret_symbolicmap::Bool, use_defaults::Bool)
   @ SciMLBase ~/.julia/packages/SciMLBase/jadet/src/remake.jl:789
 [3] remake(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}; p::Missing, interpret_symbolicmap::Bool, use_defaults::Bool, kwargs::@Kwargs{f::IntegralFunction{false, SciMLBase.FullSpecialize, Integrals.var"#22#23"{typeof(Integrals.t2ujac), Vector{Int64}, Vector{Int64}, typeof(f)}, Nothing}, domain::Tuple{Vector{Float64}, Vector{Float64}}})
   @ SciMLBase ~/.julia/packages/SciMLBase/jadet/src/remake.jl:98
 [4] init_cacheval(alg::Integrals.ChangeOfVariables{typeof(Integrals.transformation_if_inf), HCubatureJL{typeof(LinearAlgebra.norm), Nothing}}, prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}})
   @ Integrals ~/.julia/packages/Integrals/e3NH3/src/Integrals.jl:75
 [5] init(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}, alg::HCubatureJL{typeof(LinearAlgebra.norm), Nothing}; sensealg::Integrals.ReCallVJP{Integrals.ZygoteVJP}, do_inf_transformation::Nothing, kws::@Kwargs{})
   @ Integrals ~/.julia/packages/Integrals/e3NH3/src/common.jl:26
 [6] init(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}, alg::HCubatureJL{typeof(LinearAlgebra.norm), Nothing})
   @ Integrals ~/.julia/packages/Integrals/e3NH3/src/common.jl:17
 [7] solve(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}, alg::HCubatureJL{typeof(LinearAlgebra.norm), Nothing}; kwargs::@Kwargs{})
   @ Integrals ~/.julia/packages/Integrals/e3NH3/src/common.jl:104
 [8] solve(prob::IntegralProblem{false, Int64, IntegralFunction{false, SciMLBase.FullSpecialize, typeof(f), Nothing}, Tuple{Vector{Int64}, Vector{Int64}}, @Kwargs{}}, alg::HCubatureJL{typeof(LinearAlgebra.norm), Nothing})
   @ Integrals ~/.julia/packages/Integrals/e3NH3/src/common.jl:101
 [9] top-level scope
   @ ~/Documents/PhD/BsToMuMu/HistogramLogLikelihood/dummy/fail_solve.jl:17
in expression starting at /home/marco/Documents/PhD/BsToMuMu/HistogramLogLikelihood/dummy/fail_solve.jl:17

Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
julia> using Pkg; Pkg.status()
Status `~/Documents/PhD/BsToMuMu/HistogramLogLikelihood/dummy/Project.toml`
  [de52edbc] Integrals v4.5.0
  [0bca4576] SciMLBase v2.66.0
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
julia> using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
Status `~/Documents/PhD/BsToMuMu/HistogramLogLikelihood/dummy/Manifest.toml`
  [47edcb42] ADTypes v1.11.0
  [7d9f7c33] Accessors v0.1.38
  [79e6a3ab] Adapt v4.1.1
  [66dad0bd] AliasTables v1.1.3
  [4fba245c] ArrayInterface v7.17.1
  [861a8166] Combinatorics v1.0.2
  [38540f10] CommonSolve v0.2.4
  [34da2185] Compat v4.16.0
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.8
  [9a962f9c] DataAPI v1.16.0
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [8bb1440f] DelimitedFiles v1.9.1
  [31c24e10] Distributions v0.25.113
  [ffbed154] DocStringExtensions v0.9.3
  [4e289a0a] EnumX v1.0.4
  [e2ba6199] ExprTools v0.1.10
⌅ [6b7a57c9] Expronicon v0.8.5
  [1a297f60] FillArrays v1.13.0
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [46192b85] GPUArraysCore v0.2.0
  [19dc6840] HCubature v1.7.0
  [34004b35] HypergeometricFunctions v0.3.25
  [18e54dd8] IntegerMathUtils v0.1.2
  [de52edbc] Integrals v4.5.0
  [3587e190] InverseFunctions v0.1.17
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.6.1
  [73f95e8e] LatticeRules v0.0.1
  [2ab3a3ac] LogExpFunctions v0.3.28
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [e1d29d7a] Missings v1.2.0
  [4886b29c] MonteCarloIntegration v0.2.0
  [bac558e1] OrderedCollections v1.7.0
  [90014a1f] PDMats v0.11.31
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [27ebfcd6] Primes v0.5.6
  [43287f4e] PtrArrays v1.2.1
  [1fd47b50] QuadGK v2.11.1
  [8a4e6c94] QuasiMonteCarlo v0.3.3
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.27.4
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [79098fc4] Rmath v0.8.0
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [0bca4576] SciMLBase v2.66.0
  [c0aeaf25] SciMLOperators v0.3.12
  [53ae85a6] SciMLStructures v1.6.1
  [ed01d8cd] Sobol v1.5.0
  [a2af1166] SortingAlgorithms v1.2.1
  [276daf66] SpecialFunctions v2.4.0
  [90137ffa] StaticArrays v1.9.8
  [1e83bf80] StaticArraysCore v1.4.3
  [10745b16] Statistics v1.11.1
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.2
  [2efcf032] SymbolicIndexingInterface v0.3.36
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.12.0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.5.1+0
  [0dad84c5] ArgTools v1.1.2
  [56f22d72] Artifacts v1.11.0
  [2a0f44e3] Base64 v1.11.0
  [ade2ca70] Dates v1.11.0
  [8ba89e20] Distributed v1.11.0
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching v1.11.0
  [b77e0a4c] InteractiveUtils v1.11.0
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2 v1.11.0
  [8f399da3] Libdl v1.11.0
  [37e2e46d] LinearAlgebra v1.11.0
  [56ddb016] Logging v1.11.0
  [d6f4376e] Markdown v1.11.0
  [a63ad114] Mmap v1.11.0
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.11.0
  [de0858da] Printf v1.11.0
  [9a3f8284] Random v1.11.0
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization v1.11.0
  [6462fe0b] Sockets v1.11.0
  [2f01184e] SparseArrays v1.11.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [cf7118a7] UUIDs v1.11.0
  [4ec0a83e] Unicode v1.11.0
  [e66e0078] CompilerSupportLibraries_jll v1.1.1+0
  [deac9b47] LibCURL_jll v8.6.0+0
  [e37daf67] LibGit2_jll v1.7.2+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.6+0
  [14a3606d] MozillaCACerts_jll v2023.12.12
  [4536629a] OpenBLAS_jll v0.3.27+1
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.7.0+0
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.11.0+0
  [8e850ede] nghttp2_jll v1.59.0+0
  [3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading. To see why use `status --outdated -m`
  • Output of versioninfo()
julia> versioninfo()
Julia Version 1.11.2
Commit 5e9a32e7af2 (2024-12-01 20:02 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × AMD Ryzen 7 5700U with Radeon Graphics
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver2)
Threads: 1 default, 0 interactive, 1 GC (on 16 virtual cores)
Environment:
  JULIA_CONDAPKG_BACKEND = Null
  JULIA_PYTHONCALL_EXE = /usr/bin/python

Additional context

I discovered the bug since I am developing a little package that uses Integrals and yesterday my CI started failing while locally the tests passed. The difference was in the SciMLBase version.

@lxvm
Copy link
Collaborator

lxvm commented Dec 8, 2024

It looks like this has been fixed upstream. Does SciMLBase v2.67 work?

@MarcoRiggirello
Copy link
Author

Does SciMLBase v2.67 work?
On my project, yes!

@lxvm lxvm closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants