-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions of ConstantInterpolation
reported by JET.@report_opt
#389
Comments
@DaniGlez or @SouthEndMusic got a second for a bit of clean up? |
I can maybe take a look tomorrow, from a quick glance I see that at least |
Looking at the diff v5.0.0...master makes me actually wonder whether I should get rid of DataInterpolations in my code base... The type became much more complex but I'm only ever interested in the simple interpolation functionality. In my case The But for numeric |
I think it could make sense to make a SimpleInterpolations.jl... we end up with this at every library. There are 20 billion things someone wants to do and the 5 main things. Trying to accomplish both tasks with one implementation can be very difficult, sometimes just splitting it can be easier. Keep the same interface, but having a set of implementations that is just very basic and handles the 99% is helpful in a different way. This is how we ended up with SimpleDiffEq.jl, SimpleNonlinearSolve.jl, SimpleOptimization.jl, etc. |
It seems #392 and #393 fixed this particular issue here. On the master branch I get julia> using DataInterpolations, JET
julia> @report_opt ConstantInterpolation(["A", "B", "C"], [0.1, 0.2, 0.3])
No errors detected
julia> @report_call ConstantInterpolation(["A", "B", "C"], [0.1, 0.2, 0.3])
No errors detected Is it possible to make a new release? I'll report back and open a new issue if I encounter additional regressions when updating my package. |
Describe the bug 🐞
I'm upgrading from DataInterpolations 5.0.0 to the latest release and tests with
JET.@test_opt
started to fail.Expected behavior
No regression should occur when updating DataInterpolations.
Minimal Reproducible Example 👇
With DataInterpolations 5.0.0:
On the master branch:
Environment (please complete the following information):
The example above was run with Julia 1.11.3 but regressions also show up on Julia 1.10.
The text was updated successfully, but these errors were encountered: