Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoselect Correct Solver for Nonlinear Least Squares #123

Closed
avik-pal opened this issue Oct 13, 2023 · 2 comments · Fixed by #137
Closed

Autoselect Correct Solver for Nonlinear Least Squares #123

avik-pal opened this issue Oct 13, 2023 · 2 comments · Fixed by #137
Labels
enhancement

Comments

@avik-pal
Copy link
Member

Currently, we fix the solver at the time of algorithm creation. This means for a NLS problem our defaults are incorrect.

Easy solution:

  • Keep nlsolve as nothing
  • Run a concretize step
    • If not nothing then return the solver
    • If nothing choose the solver based on the generated problem
@avik-pal
Copy link
Member Author

I tried this but it completely kills type stability. Which is not unexpected since the solver choice is dependent on runtime parameters.

@avik-pal
Copy link
Member Author

avik-pal commented Nov 4, 2023

NonlinearSolve.jl has a nothing dispatch for NonlinearProblem. All we need to do now is add one for NonlinearLeastSquaresProblem. Once that is done, we can set the default nlsolve to be nothing

@avik-pal avik-pal mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use PolyAlgorithms for Nonlinear Solves avik-pal/BoundaryValueDiffEq.jl
1 participant
@avik-pal