Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxDatePicker): implement min and max property #2196

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

larsrickert
Copy link
Collaborator

Relates to #1818

Also fix the bug where the value is always undefined, when using type="datetime-local" by removing the usage of valueAsDate which does not work with date+time.

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner December 2, 2024 10:16
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 6320c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Minor
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 self-assigned this Dec 4, 2024
@larsrickert larsrickert requested a review from JoCa96 December 4, 2024 08:23
@larsrickert larsrickert merged commit c8beae4 into main Dec 5, 2024
19 checks passed
@larsrickert larsrickert deleted the feat/1818-min-max branch December 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants